Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update depinfo #1361

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Update depinfo #1361

merged 4 commits into from
Oct 25, 2023

Conversation

Midnighter
Copy link
Member

@Midnighter Midnighter commented Oct 19, 2023

  • fix #(issue number)
  • description of feature/fix
  • tests added/passed
  • add an entry to the next release

Update the version of depinfo to >2 and change issue templates to use the form input.

@Midnighter Midnighter self-assigned this Oct 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (devel@75f4095). Click here to learn what that means.
Report is 3 commits behind head on devel.

❗ Current head b56eb4a differs from pull request most recent head d42a113. Consider uploading reports for the commit d42a113 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             devel    #1361   +/-   ##
========================================
  Coverage         ?   83.85%           
========================================
  Files            ?       66           
  Lines            ?     5499           
  Branches         ?     1257           
========================================
  Hits             ?     4611           
  Misses           ?      572           
  Partials         ?      316           
Files Coverage Δ
src/cobra/util/util.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cdiener cdiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I would prefer questions in the discussion section I think to have them all in one place.

.github/ISSUE_TEMPLATE/02-question.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/01-bug-report.yaml Show resolved Hide resolved
@Midnighter
Copy link
Member Author

Is this more like you were thinking?

Copy link
Member

@cdiener cdiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thanks!

@Midnighter Midnighter merged commit 2425b41 into devel Oct 25, 2023
@Midnighter Midnighter deleted the update-depinfo branch October 25, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants