Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6: Changed some of the Hashicorp Vault references in the docs to OpenBao #7

Merged
merged 5 commits into from
May 20, 2024

Conversation

naphelps
Copy link
Member

References: #6

Changes:

  • Issue 6: Changed some of the Hashicorp Vault references in the docs to OpenBao.

@naphelps
Copy link
Member Author

@jessebot Some doc changes. Cleaned up 1 or 2 items that got missed in your pull request.

Copy link
Member

@JanMa JanMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter CI check currently fails because the Chart needs a version bump whenever files in the charts/openbao folder are changed. Please bump the chart version in the chart.yaml file

charts/openbao/README.md Show resolved Hide resolved
@jessebot
Copy link

jessebot commented May 18, 2024

So, we kinda have an issue where even after you bump the chart version, the chart linter will still fail, because there's a few things left over from hashicorp that need to be fixed to please the linter in values.yaml:

  • there are some commented lines that don't have a space after the #
  • the prometheusRules parameters are indented too far compared to the rest of the values.yaml (how did this ever work? 🤔 )
  • the main image is still wrong.

I've addressed all of the above in #8 so you can still do one of the following:

  1. force merge this, then I can pull the changes to my fork's main branch, then rebase and force push to my feature branch, and then the tests should pass in my Issue 3: update base vault images to point at quay.io/openbao/openbao; add more helm docs #8 and we can merge that into main for this repo

  2. open a PR from with these changes, naphelps:issue-6, to my feature branch in Issue 3: update base vault images to point at quay.io/openbao/openbao; add more helm docs #8, I merge them into my feature branch, and then we merge Issue 3: update base vault images to point at quay.io/openbao/openbao; add more helm docs #8 in

3. I can open a PR to naphelps:issue-6, you can merge my feature branch into naphelps:issue-6, and then we merge this PR into main. Can't do this, GitHub doesn't let me open a PR to that fork for some reason 🤷

@naphelps naphelps merged commit b59b6e5 into openbao:main May 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants