Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix embedding model mismatch between Question_answering_using_embeddi… #1332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sheldonrampton
Copy link

Summary

The article on "Embedding_Wikipedia_articles_for_search" is intended to show how the embeddings were generated for the article on "Question_answering_using_embeddings." However, the "Embedding_Wikipedia" code specifies a different EMBEDDING_MODEL than the "Question_answering" model. As a result, the "Question_answering" code fails to understand the embeddings and returns returns "I could not find an answer" when it tries to answer the questions. This pull request fixes that EMBEDDING_MODEL mismatch.

…ngs.ipynb and Embedding_Wikipedia_articles_for_search.ipynb
@sheldonrampton
Copy link
Author

sheldonrampton commented Aug 2, 2024

After submitting this pull request, I realized that the embeddings file which is referenced in
https://cookbook.openai.com/examples/question_answering_using_embeddings
references this embeddings path:
https://cdn.openai.com/API/examples/data/winter_olympics_2022.csv
which was generated using text-embedding-ada-002 as its EMBEDDING_MODEL. If you accept my pull request, therefore, you will need to regenerate the embeddings file using text-embedding-3-small as the embedding model.

Alternately, you could fix the embedding model mismatch by using text-embedding-ada-002 for both the "Question answering" and the "Embedding Wikipedia" articles.

Copy link

github-actions bot commented Oct 2, 2024

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Oct 2, 2024
@sheldonrampton
Copy link
Author

This has still not been fixed.

@github-actions github-actions bot removed the Stale label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant