Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ub in conversion from char array (without eof) to string_view #33

Merged
merged 1 commit into from
Sep 4, 2024
Merged

fix: ub in conversion from char array (without eof) to string_view #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 25 additions & 12 deletions include/opengemini/impl/enc/LineProtocolEncoder.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ class LineProtocolEncoder {
std::ostringstream os_;

static constexpr auto ELEMENT_LF{ '\n' };
static constexpr auto ELEMENT_EOF{ '\0' };
static constexpr auto ELEMENT_COMMA{ ',' };
static constexpr auto ELEMENT_EQUAL{ '=' };
static constexpr auto ELEMENT_SPACE{ ' ' };
Expand All @@ -63,18 +64,30 @@ class LineProtocolEncoder {
static constexpr auto ELEMENT_TRUE{ 'T' };
static constexpr auto ELEMENT_FALSE{ 'F' };

static constexpr char ESCAPE_CHARS_TAG[]{ ELEMENT_COMMA,
ELEMENT_EQUAL,
ELEMENT_SPACE };

static constexpr char ESCAPE_CHARS_FIELD_KEY[]{ ELEMENT_COMMA,
ELEMENT_EQUAL,
ELEMENT_SPACE };
static constexpr char ESCAPE_CHARS_FIELD_VALUE[]{ ELEMENT_DQUOTE,
ELEMENT_BSLASH };

static constexpr char ESCAPE_CHARS_MEASUREMENT[]{ ELEMENT_COMMA,
ELEMENT_SPACE };
static constexpr char ESCAPE_CHARS_TAG[]{
ELEMENT_COMMA,
ELEMENT_EQUAL,
ELEMENT_SPACE,
ELEMENT_EOF,
};

static constexpr char ESCAPE_CHARS_FIELD_KEY[]{
ELEMENT_COMMA,
ELEMENT_EQUAL,
ELEMENT_SPACE,
ELEMENT_EOF,
};
static constexpr char ESCAPE_CHARS_FIELD_VALUE[]{
ELEMENT_DQUOTE,
ELEMENT_BSLASH,
ELEMENT_EOF,
};

static constexpr char ESCAPE_CHARS_MEASUREMENT[]{
ELEMENT_COMMA,
ELEMENT_SPACE,
ELEMENT_EOF,
};
};

} // namespace opengemini::impl::enc
Expand Down