Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technology types #116

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Technology types #116

wants to merge 4 commits into from

Conversation

HauHe
Copy link
Contributor

@HauHe HauHe commented Oct 21, 2021

This PR addresses #59
It adds a list of technology types that can be used fill the spaceholder <Specification>.
E.g. given when having variable names like: Capital Cost|<Fuel>|<Specification>.

The list is probably not complete and one could discuss how to name the technologies. Are abbreviations ok? Variable names might get very long if not.

Anyhow, happy for suggestions and contributions for improving the list.

@HauHe
Copy link
Contributor Author

HauHe commented Oct 21, 2021

Hi @erikfilias, @danielhuppmann, @sandrinecharousset,

here the promised draft of a list of technologies. Please let me know what you think and feel free to add or suggest changes!

@danielhuppmann
Copy link
Member

Thanks @HauHe for starting this list, will be useful starting place to shorten the variable names. I made some suggestions for clarity and also to bring the PR in line with the general recomendations, see https://github.com/openENTRANCE/nomenclature/tree/master/nomenclature/definitions/variable#naming-convention-for-variables

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the actual inline-suggestions weren't included in the earlier comment...

Fuel cell:
description: Fuel cells

OCGT:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to use Gas Turbine|Open Cycle

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the technology then be called Gas Turbine?
One could then define the <Specification>``Open Cycleand Combined Cycle

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps one could then also define a file specification_types.yaml. Or does the information then get too dispersed? What do you think @sandrinecharousset @erikfilias @danielhuppmann ?

description: Open-Cycle Gas Turbine
ccs: True

Generation II:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to use Nuclear|Generation 2 (same for next technologies) and to more clearly explain in the description what generation 2 vs. 3 vs. 4 is (year of development, other technical specifications)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generation 2 is indeed somehow unspecific, but Nuclear is already covered by the <Fuel>isn't it?

Copy link
Contributor Author

@HauHe HauHe Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <Fuel>question is also valid for several other of your comments. My thought is that if we say here Nuclear|Generation 2or Wind|Onshore instead of Generation 2 and Onshore then one might end up with variable names containing Nuclear|Nucelar|Generation 2 and Wind|Wind|Onshoresince we say in the naming convention <Fuel>|<Technology>|<Specification>

Generation IV:
description: Nuclear power plant of the fourth generation

SMR reactor:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to use Nuclear|Small Modular Reactor

Tidal:
description: Power generation using tidal currents

PV:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to use Solar|Photovoltaics

PV:
description: Solar Photovoltaics

CSP:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to use Solar|Concentrated Solar Power

CSP:
description: Concentrating Solar Power

Onshore:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to add Wind|Onshore, also for Offshore

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielhuppmann I am a bit lost understanding the difference between this list and the fuel_type list as there are some duplicates (eg Wind|Onshore, Wind|Offshore you just proposed to add...); What if one list is modified and not consistent with the other?

Copy link
Contributor Author

@HauHe HauHe Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point @sandrinecharousset.
That's why I had listed Onshoreand Offshore and other technologies without their <Fuel>, to keep the list separated relating to the spaceholders in the naming convention they can fill.
However, amybe in some cases it might be confusing or at least not 100% clear what a technology name relates to.
I'd still lean towards keeping fuels and technologies separated.

@danielhuppmann
Copy link
Member

danielhuppmann commented Oct 29, 2021

Taking this discussion out of the individual review comments to the meta-level of this PR. I see some confusion between the generic description of a variable in the description and README's, e.g., <Fuel>|<Technology>|<Specification>, versus the tag-lists that are used to automatically create permutations of variables using placeholders (tags).

We currently have not (yet?) implemented a method to only fill specific combinations of placeholders (like use Specification=Offshore only with Technology=Wind but not with Technology=Nuclear. Therefore, the pragmatic approach would be to have a technology-placeholder list that actually holds meaningful combinations of Fuel-Technology-Specifications...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants