-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add swyddfa.esbonio
(#741)
#742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tchernobog 👋, thanks for the contribution.
I am happy to add the extension, but the size we build is about 180KB, while the official extension is somewhere about 1.4MB. I think there are some build steps we're missing
cda168d
to
6fb78c2
Compare
6fb78c2
to
7cc7404
Compare
Thanks @filiptronicek for catching this. I fixed the build, but I still have one problem. As far as I can tell, the code in Unfortunately, the extension uses a non-standard format. The latest tag is currently for an older release from a different branch than mainline (called here Here we need to consider only those tags that match The latest tag is for During the build it's easy for me to fix the checked out tag, but as the context is already set at that point, the wrong version is published: {
"context": {
"msVersion": "0.11.0",
"msLastUpdated": "2023-03-06T22:51:28.410Z",
"msInstalls": 13902,
"msPublisher": "swyddfa",
"version": "0.11.0",
"repo": "/tmp/repository/main",
"ref": "esbonio-language-server-v0.16.4"
}
} How can this be fixed? I don't see anything in the JSON schema. |
Thanks for looking into this further, @tchernobog. Does this mean that the currently built package for The setup here looks quite complex and difficult to maintain, so I think it would be best to publish the current latest version manually and wait for the author to publish the 1.0 release themselves as you mentioned. |
@filiptronicek the results in term of package seem fine. The only problem is that the deduced version seems wrong (0.11.0). If the result of this run is indeed The build job seems fine: https://github.com/open-vsx/publish-extensions/actions/runs/7893644227/job/21542661844?pr=742#step:9:418 The question is if the context is still used when publishing somehow, because it shows a different version: https://github.com/open-vsx/publish-extensions/actions/runs/7893644227/job/21542661844?pr=742#step:9:142 If the context is ignored while pushing to the marketplace, then this change should be fine. |
I see the issue now, thanks for pointing it out. When publishing, this context is not used and the only version info, which is what is actually listed in the packaged extension (Open VSX takes care of that). I am publishing v0.92.1 now |
Published: https://open-vsx.org/extension/swyddfa/esbonio 🎉 |
Description
Add
swyddfa.esbonio
(#741).Author has manifested interest in publishing to OpenVSX once this hits version 1.0, but I would like a temporary solution for now as 1.0 might be several months away.