Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add revilowaldow.5etools-language-server #722

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Add revilowaldow.5etools-language-server #722

merged 1 commit into from
Dec 21, 2023

Conversation

Spappz
Copy link
Contributor

@Spappz Spappz commented Nov 22, 2023

  • I have read the note above about PRs contributing or fixing extensions
  • I have tried reaching out to the extension maintainers about publishing this extension to Open VSX (if not, please create an issue in the extension's repo using this template).
  • This extension has an OSI-approved OSS license (we don't accept proprietary extensions in this repository)

Description

This PR adds the 5eTools Language Server; the developer has unfortunately been unresponsive.

License is MIT-0.

Thanks!

@filiptronicek
Copy link
Collaborator

Hi there @Spappz 👋 and thanks for your contribution. Could you please try raising an issue on the respective repo first? It seems that there were no issues yet and the extension is regularly being updates 🙏.

@Spappz
Copy link
Contributor Author

Spappz commented Nov 23, 2023

I actually spoke with the developer directly and suggested publishing to Open VSX that way. I included a step-by-step process (both for doing it themselves or adding the module here) but, unfortunately, they were very clear that they had no intention of doing either ever. So, granted not 'unresponsive to contact', but it was certainly 'unresponsive to the proposition'!

I can raise the issue just for them to flag it down if you'd like the confirmation either way. ¯\_(ツ)_/¯

@revilowaldow
Copy link

Evening, as @Spappz indicates I have no interest in publishing to a second marketplace, however I’m happy for it to be automatically republished on my behalf through this method.

The whole thing feels very circular to me and I don’t want yet another account. Hypothetically the intent is to avoid telemetry, but we’re all using GitHub here; I’m publishing to the Microsoft marketplace, from vscode, on my windows pc. A core feature of the extension is to pull a schema (comprised of a hundred or so files) for data validation, directly from GitHub, which will definitely be tracking who’s requesting them from where how often etc. Then the first step of publishing an open vsx extension is to create an account, and immediately link that to GitHub. Then I have to accept a publisher agreement with a list of third parties you use, and then set up a PAT. And then every time I publish I’ve got to do all the admin twice, or do a load of up front CI pipeline work for which I do not care.

Again, I’m happy for the extension to be republished on my behalf, however I will not be creating an account.

@Spappz
Copy link
Contributor Author

Spappz commented Dec 21, 2023

Hi, is there anything else to be done here before merge? A couple others and I are eager to see it in the repo given Revilowaldow's position above 😁

Copy link
Collaborator

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Spappz for the context. I am happy to have the extension on Open VSX, where it should land sometime tomorrow.

@filiptronicek filiptronicek merged commit f0bd783 into open-vsx:master Dec 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants