Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matplotlib #51

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Matplotlib #51

wants to merge 11 commits into from

Conversation

m-kuhn
Copy link
Contributor

@m-kuhn m-kuhn commented Oct 11, 2024

No description provided.

Comment on lines -86 to +92
COMMAND ${env} "${z_vcpkg_python_func_python}" -m gpep517 build-wheel --wheel-dir "${z_vcpkg_wheeldir}" --output-fd 1 ${build_ops}
COMMAND ${env} "${PYTHON3}" -m gpep517 build-wheel --wheel-dir "${z_vcpkg_wheeldir}" --output-fd 1 ${build_ops}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Neumann-A what was your intent with z_vcpkg_python_func_python? Should this be the system python or something provided through vcpkg?

In the current state of this repository, it happens to be system python. In this case I think we'll need to acquire build dependencies (e.g. gpep517) similar to the py-meson approach above
https://github.com/open-vcpkg/python-registry/pull/51/files#diff-84817e4d8adab62c915c43e6a931b961f018d05eca77fc90b42fc62d032e8298R27

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was to have a single place which handles which python gets used instead of having to change all vcpkg_execute_required_process calls

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where would this ideally be defined? in vcpkg-python-scripts/vcpkg-port-config.cmake ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants