-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move DNS lookup metric outside of .NET semconv #785
Conversation
@open-telemetry/dotnet-approvers what do you think about this approach? We have a few more places where .NET either uses experimental attributes on stable metrics or declares common-purpose metrics like The proposal here is to move such things away into general semconv as experimental and, as a precaution, remove table auto-generation from .NET preventing possible breaking changes on .NET docs. The context: we're explicitly annotating stability on attributes and metrics and realized we have some conflicts. Oops |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense, given the history behind it (.NET marked it all as stable) and our intention to explicitly mark the stability on all things. Waiting for the .NET folks to chime in.
@lmolkova The change looks good to me. But I think we should make the note visible on .NET side explaining what does stable mean from .NET's perspective?. |
This seems fine to me. It does raise a larger question... if there was concern about unintended breaking changes on the .NET docs for this metric, does that same risk exist for other metrics?
I'm not sure we've ever officially defined it, but I interpret it to mean we shipped the behavior and we'd treat it similar to any other .NET API behavior in terms of preserving back-compat. Namely that means we'd try hard not to break it without very good reason and if we did introduce a breaking change it would be officially documented. |
@noahfalk not for stable ones, the problem that just became obvious that .NET stable document uses metrics and attributes that are not defined as stable. I.e. there are no breaking changes coming to There are other metrics I want to extract from .NET in follow-up PRs - everything that starts with I'd like to do the same trick I've done in this PR with them. Assuming we do this, I think we can handle changes in the following way
|
This plan makes sense to me. I think it's the best we can do given the circumstances. |
@open-telemetry/semconv-dotnet-approver any concerns here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, left few comments
Fixes #404
Changes
This PR moved DNS lookup duration outside of .NET semantic conventions.
It removes MD generation from .NET metric definition as it's frozen in time and should not get any updates or changes on the common metric.
It helps to untie .NET semconv stability from the unstable OTel parts it depends upon and helps with #781
Merge requirement checklist
[chore]
schema-next.yaml updated with changes to existing conventions.