Remove service.version from list of attributes with dedicated env var #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Aug 16, 2023
Oberon00
approved these changes
Aug 16, 2023
joaopgrassi
approved these changes
Aug 16, 2023
10 tasks
|
Actually we didn't come to an agreement when discussing this in the Spec, so yes, let's remove this. |
carlosalberto
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removes service.version from list of attributes with an env var. I tried looking for it but couldn't find it, it seems there was an attempt to add that wasn't merged
open-telemetry/opentelemetry-specification#3573
I'm not sure if that will be revived but if it does, I guess this could be added back after the variable gets defined.
Merge requirement checklist
Didn't add to CHANGELOG since it's just a docs change, not spec change, but let me know if it should be there