Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: OTEL_SEMCONV_STABILITY_OPT_IN is important instrumentation libraries supporting v1.25.0 and prior #1470

Closed
wants to merge 1 commit into from

Conversation

pellared
Copy link
Member

@pellared pellared commented Oct 11, 2024

Addresses open-telemetry/opentelemetry-go-contrib#6172 (comment)

Most likely it was a "copy-paste" error from messaging spans and metrics or someone has forgotten to bump the version.

Do you want a changelog entry for this?

CC @trask

@pellared pellared requested review from a team as code owners October 11, 2024 19:35
@pellared pellared changed the title db: OTEL_SEMCONV_STABILITY_OPT_IN is imporant for v1.25.0 and prior db: OTEL_SEMCONV_STABILITY_OPT_IN is important instrumentation libraries supporting v1.25.0 and prior Oct 11, 2024
@trask
Copy link
Member

trask commented Oct 11, 2024

I'm not sure this is right, the pause was put into place in #733, which was prior to the v1.25.0 release.

and there were breaking database changes in v1.25.0:

@pellared
Copy link
Member Author

@trask, you are right. Closing. Sorry for inconvenience and thanks for your help.

@pellared pellared closed this Oct 11, 2024
@pellared pellared deleted the db-opt-in branch October 11, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants