Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render events with bodies #1464

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Render events with bodies #1464

wants to merge 3 commits into from
+275 −185

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Oct 10, 2024 •
edited
Loading

  • Add templates to render event bodies
  • Updates to existing events:
    • Add missing stability (stable) on exception span event
    • Update RPC, device lifecycle, and feature flags events - move brief/notes from markdown to yaml.
    • Uncomment azure resource log definition

@lmolkova lmolkova requested review from a team and tigrannajaryan as code owners October 10, 2024 02:09
@lmolkova lmolkova marked this pull request as draft October 10, 2024 02:09
@lmolkova lmolkova marked this pull request as ready for review October 11, 2024 01:59
@lmolkova lmolkova changed the title [WIP] Render events with bodies Render events with bodies Oct 11, 2024
@lmolkova lmolkova added the Skip Changelog Label to skip the changelog check label Oct 11, 2024
@lmolkova lmolkova mentioned this pull request Oct 11, 2024
Open
3 tasks
@lmolkova
Copy link
Contributor Author

/cc @open-telemetry/semconv-feature-flag-approvers @open-telemetry/semconv-event-approvers

jsuereth
jsuereth approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

templates/registry/markdown/snippet.md.j2 Outdated Show resolved Hide resolved
templates/registry/markdown/event_macros.j2 Outdated Show resolved Hide resolved
templates/registry/markdown/examples_macros.j2 Show resolved Hide resolved
lmolkova
lmolkova commented Oct 11, 2024
View reviewed changes
docs/rpc/rpc-spans.md Outdated Show resolved Hide resolved
lmolkova
lmolkova commented Oct 14, 2024
View reviewed changes
model/azure/logs.yaml Outdated Show resolved Hide resolved
joaopgrassi
joaopgrassi approved these changes Oct 17, 2024
View reviewed changes
docs/azure/events.md Outdated Show resolved Hide resolved
@lmolkova lmolkova requested a review from a team as a code owner October 17, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuereth jsuereth jsuereth approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@MSNev MSNev MSNev left review comments

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan tigrannajaryan is a code owner

Assignees
No one assigned
Labels
Skip Changelog Label to skip the changelog check
Projects
Logs SIG
Status: In progress
Semantic Conventions Triage
Status: Ready to be Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lmolkova @jsuereth @joaopgrassi @MSNev @AlexanderWert