-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add system specific conventions for OpenAI #1385
Conversation
I'm creating this as Draft since its the first vendor specific conventions we are adding to the gen_ai area.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Left some comments
I've sent a similar one for Azure AI Inference - #1393 (without metrics though - no plans to report anything custom there yet).
Either way works for me. I'd keep them in one file until it grows too big.
Yes, the point is to describe all attributes that are applicable (and how if it's not obvious). Otherwise it's not clear which generic ones apply to openai. |
Thanks, I brought this up in the Azure inference list as well, but is there a way to highlight, sort, or otherwise make it clear which ones are specific to openai? One can scan the list and fine the namespaces, but it'd be easier if they stood out visually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @drewby
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only glitch is service tiers, and I wonder if there would be difference vs OpenAI the platform vs Azure OpenAI. Certainly emulators would have differences. Should we mention the openai api docs, but caution that platform differences apply in exact values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments, but LGTM overall!
8477fc6
to
1582ea4
Compare
70b4297
to
69449ff
Compare
c13a5f8
to
53982fd
Compare
Co-authored-by: Liudmila Molkova <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>
Fixes #1370
Changes
Adds system specific attributes for OpenAI.
Adds an openai.md document to outline the attributes that should be added to spans in addition to the general attributes. It also outlines the attributes which should be added to generative AI metrics.
Merge requirement checklist
[chore]