-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource: Allow service.version to be auto-populated by SDKs #1338
base: main
Are you sure you want to change the base?
resource: Allow service.version to be auto-populated by SDKs #1338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
since this is SDK spec, should it be in opentelemetry-specification instead? |
Yeah I was thinking the same when I was reviewing. It feels similar to telemetry sdk attributes https://github.com/open-telemetry/semantic-conventions/blob/main/docs/resource/README.md#telemetry-sdk. |
FWIW spec doesn't mention And delegates the definition of I feel we need to update semconv anyway. Let's bring it up in Monday SemConv and/or Tue Spec call to highlight this change and discuss whether we should have something in the spec about |
@@ -20,6 +20,13 @@ groups: | |||
type: string | |||
brief: > | |||
The version string of the service API or implementation. The format is not defined by these conventions. | |||
note: | | |||
When possible, SDKs MAY use language/platform-specific capabilities to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This normative language belongs here: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/resource/README.md#semantic-attributes-with-sdk-provided-default-value
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Changes
service.version
if there are standard ways to do it for the SIGDetails
.NET has some built-in mechanisms for versioning assemblies: Assembly versioning.
What this PR seeks to do is make it allowable for SDKs to populate
service.version
from known sources if the user explicitly enables/requests auto-population.Here is a PoC branch I did of what this might look like in .NET SDK: https://github.com/open-telemetry/opentelemetry-dotnet/compare/main...CodeBlanch:resource-service-version-auto-resolution?expand=1
This support was requested by a user: open-telemetry/opentelemetry-dotnet#5703.
Merge requirement checklist
[chore]