New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTel diagram: drop fill color in support of dark mode #5436

Merged

chalin merged 1 commit into open-telemetry:main from chalin:chalin-otel-diagram-no-fill-2024-10-18

Oct 18, 2024

Contributor

chalin commented Oct 18, 2024 •

edited

Loading

Illustrates minimally intrusive solution to Review visualizations for dark/light mode compatibility #5361
Drops single fill attribute from svg rect, in support of dark mode:
Preview: https://deploy-preview-5436--opentelemetry.netlify.app/docs/

Screenshots

Before:

After:

chalin requested a review from a team as a code owner

October 18, 2024 11:56

chalin added the design/style label

chalin mentioned this pull request

Adjust visualizations for dark/light mode compatibility #5434

Closed


          Otel diagram: drop fill color in support of dark mode

58ed793

chalin force-pushed the chalin-otel-diagram-no-fill-2024-10-18 branch from 463b564 to 58ed793 Compare

October 18, 2024 12:16

svrnm approved these changes

View reviewed changes

chalin merged commit a2fd8c4 into open-telemetry:main

17 checks passed

chalin deleted the chalin-otel-diagram-no-fill-2024-10-18 branch

October 18, 2024 13:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels