Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[outreachy] Redesign labels to be distinguishable from actual buttons #5432

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Comfyydev
Copy link

Details

This PR implements a redesign of the labels used in the registry components to ensure that labels and buttons are easily identifiable, preventing any confusion between interactive and non-interactive elements.

Before

Screenshot from 2024-10-18 08-36-23

After

Screenshot from 2024-10-18 08-20-35

Fixes #5306

@Comfyydev Comfyydev requested a review from a team as a code owner October 18, 2024 07:43
Copy link

linux-foundation-easycla bot commented Oct 18, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Comfyydev / name: Comfort Oyewole (a9f967e)

@Comfyydev
Copy link
Author

@svrnm Could you please review my PR? Thanks.

@svrnm svrnm changed the title Redesign labels to be distinguishable from actual buttons [outreachy] Redesign labels to be distinguishable from actual buttons Oct 18, 2024
@svrnm svrnm added outreachy Issues for Outreachy Participants enhancement New feature or request ux labels Oct 18, 2024
assets/scss/_registry.scss Outdated Show resolved Hide resolved
assets/scss/_registry.scss Outdated Show resolved Hide resolved
@Comfyydev
Copy link
Author

@svrnm I've updated the PR and implemented the requested changes.
Could you please review it?
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request outreachy Issues for Outreachy Participants ux
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[outreachy] Registry: Redesign labels to be distinguishable from actual buttons
2 participants