Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Ensure spec processing works even if path contains a space #5422

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Oct 16, 2024

  • Fixes Build fails when within a folder with spaces #5359
  • My solution was to opt for relative paths inside of the cp-pages.sh script, and make the (very reasonable assuption) that the script is being run from the repo root. I can't recall why I opted for absolute path names. None of the directory names inside of the repo contain any spaces, so we're good.
  • Closes fix: add qoutation marks around bash variables #5377 by superseding it
  • I've tested this from inside a folder whose name contains a space and the build still works.
    @FatumaA, can you confirm (once this lands)?

@chalin chalin added the CI/infra CI & infrastructure label Oct 16, 2024
@chalin chalin requested a review from a team as a code owner October 16, 2024 21:46
@chalin chalin force-pushed the chalin-im-cp-pages-relative-paths-2024-10-16 branch from 675563a to 38ecdbd Compare October 18, 2024 11:23
@chalin chalin merged commit b3bf36e into open-telemetry:main Oct 18, 2024
17 checks passed
@chalin chalin deleted the chalin-im-cp-pages-relative-paths-2024-10-16 branch October 18, 2024 12:14
@chalin chalin mentioned this pull request Oct 18, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Build fails when within a folder with spaces
2 participants