-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define Event API arguments and mapping to log record #3772
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from my comment about the event.domain
rewording and including portions of #3749
LGTM.
Why 10? Are we trying to be in the middle of the "info" range for some reason? Note that mappings of other formats to Otel use INFO=9 as the level for informational events. Should we use the same level for Otel-generated events? I agree with all other assertions in the PR description. |
We discussed that a good default severity would be an "info" level, but I took some agency with the selection of 10 to stay in the middle of the info range. I don't feel strongly about this though and the appendix you point to seems to be a pretty good reason to select INFO=9 as the default. |
Draft PR where I've prototyped these changes in opentelemetry-java: open-telemetry/opentelemetry-java#6001 |
Event domain and name are now merged, I think this needs to be updated to reflect that (or a separate is needed to do just that). |
…y-specification into event-api-args
I've rebased this now that event domain and name are merged in #3749. |
@jack-berg CHANGELOG entry? |
Changelog entry added @carlosalberto 👍 |
Will merge tomorrow if there are no additional comments. |
In the 11/17/23 Event SIG we discussed and reached agreement on a number of things related to the Event API and how its parameters should manifest on resulting log record:
event.name
(event.domain is going away in Merge event's domain and name #3749) should be an AnyValue and recorded to the log record body.Note that there is going to be a corresponding PR in
semantic-conventions
which says that Events put their payload in the LogRecord#Body field.