Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rpc-metrics.md #3623

Closed
wants to merge 1 commit into from
Closed

Update rpc-metrics.md #3623

wants to merge 1 commit into from

Conversation

larry-safran
Copy link

Add descriptions from gRPC's Status.java file for error codes listed in the grpc section.

Add descriptions for gRPC's Status.java file for error codes.
@larry-safran larry-safran requested review from a team July 25, 2023 00:39
@Oberon00
Copy link
Member

Thank you for your contribution! Please re-submit this PR against https://github.com/open-telemetry/semantic-conventions, as the semantic conventions were recently moved there.

Also note that the markdown must be changed together with the YAML model (you can generate the markdown from YAML): https://github.com/open-telemetry/semantic-conventions/blob/v1.21.0/model/trace/rpc.yaml#L103-L158

@Oberon00 Oberon00 closed this Jul 25, 2023
@larry-safran larry-safran deleted the patch-1 branch December 28, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants