Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the cardinality limit section #3593

Merged
merged 8 commits into from
Jul 14, 2023
Merged

Clarify the cardinality limit section #3593

merged 8 commits into from
Jul 14, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 12, 2023

  1. Currently the term "view" is overused within the section. It is used to mean the SDK, views, and aggregators. This replaces the term with an appropriate replacement
  2. Clarify the priority order for how a cardinality limit is configured within its own new section
  3. Create a section for the overflow attributes

@MrAlias MrAlias added area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory labels Jul 12, 2023
@MrAlias MrAlias requested review from a team July 12, 2023 16:52
@reyang reyang merged commit 7181388 into open-telemetry:main Jul 14, 2023
6 checks passed
@MrAlias MrAlias deleted the cardinality-limit-refactor branch July 14, 2023 19:18
@MrAlias MrAlias added the editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@jsuereth jsuereth jsuereth approved these changes

Assignees

@jsuereth jsuereth

Labels
area:sdk Related to the SDK editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrAlias @jsuereth @reyang