Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add synchronous gauge #1718

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: add synchronous gauge #1718

wants to merge 10 commits into from
+129 −2

Conversation

xuan-cao-swi
Copy link
Contributor

Description:

Add simple gauge metrics that only record last value of recording.

Closes #1704

TODO:

  1. Replace the default aggregation with last_value once this pull request is merged.
  2. Update the test case to better represent how a gauge should behave differently from a counter.
  3. Update the metrics exporter to include the gauge type.

@xuan-cao-swi xuan-cao-swi changed the title feat: add gauge feat: add synchronous gauge Sep 4, 2024
kaylareopelle
kaylareopelle reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this, Xuan! Even more reason to get #1604 merged.

metrics_api/lib/opentelemetry/metrics/instrument/gauge.rb Outdated Show resolved Hide resolved
metrics_api/lib/opentelemetry/metrics/instrument/gauge.rb Outdated Show resolved Hide resolved
metrics_api/lib/opentelemetry/metrics/instrument/gauge.rb Outdated Show resolved Hide resolved
metrics_sdk/lib/opentelemetry/sdk/metrics/instrument/gauge.rb Outdated Show resolved Hide resolved
metrics_sdk/lib/opentelemetry/sdk/metrics/instrument/gauge.rb Outdated Show resolved Hide resolved
metrics_sdk/lib/opentelemetry/sdk/metrics/instrument/gauge.rb Outdated Show resolved Hide resolved
metrics_sdk/lib/opentelemetry/sdk/metrics/instrument/gauge.rb Outdated Show resolved Hide resolved
kaylareopelle
kaylareopelle requested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to mark this as "request changes" because I don't think we should merge this in until it uses LastValue as the default aggregation.

xuan-cao-swi and others added 8 commits September 19, 2024 11:42
@xuan-cao-swi @kaylareopelle
Update metrics_api/lib/opentelemetry/metrics/instrument/gauge.rb
df10abf 
Co-authored-by: Kayla Reopelle <[email protected]>
@xuan-cao-swi @kaylareopelle
Update metrics_api/lib/opentelemetry/metrics/instrument/gauge.rb
71ebe5b 
Co-authored-by: Kayla Reopelle <[email protected]>
@xuan-cao-swi @kaylareopelle
Update metrics_api/lib/opentelemetry/metrics/instrument/gauge.rb
d0f510a 
Co-authored-by: Kayla Reopelle <[email protected]>
@xuan-cao-swi @kaylareopelle
Update metrics_sdk/lib/opentelemetry/sdk/metrics/instrument/gauge.rb
80ebbf8 
Co-authored-by: Kayla Reopelle <[email protected]>
@xuan-cao-swi @kaylareopelle
Update metrics_sdk/lib/opentelemetry/sdk/metrics/instrument/gauge.rb
d7e6b54 
Co-authored-by: Kayla Reopelle <[email protected]>
@xuan-cao-swi @kaylareopelle
Update metrics_sdk/lib/opentelemetry/sdk/metrics/instrument/gauge.rb
e0e373a 
Co-authored-by: Kayla Reopelle <[email protected]>
@xuan-cao-swi @kaylareopelle
Update metrics_sdk/lib/opentelemetry/sdk/metrics/instrument/gauge.rb
9078b84 
Co-authored-by: Kayla Reopelle <[email protected]>
@xuan-cao-swi
create gauge api doc
b9642e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaylareopelle kaylareopelle kaylareopelle requested changes

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@arielvalentin arielvalentin Awaiting requested review from arielvalentin arielvalentin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Synchronous Gauge Instrument
2 participants
@xuan-cao-swi @kaylareopelle