feat: Update metrics configuration patch #1548
Conversation
kaylareopelle
changed the title
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
|
Blocked by #1551 |
kaylareopelle
changed the title
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
kaylareopelle
force-pushed
the
update-configuration-patch
branch
from
86a9337
to
f0c7663
Compare
…variable The environment variable has options for: * console (default) * otlp * in-memory * none Like the Traces exporter, more than one exporter can be configured
kaylareopelle
force-pushed
the
update-configuration-patch
branch
from
f0c7663
to
8ec788b
Compare
kaylareopelle
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam and
robbkidd
as code owners
metrics_sdk/lib/opentelemetry/sdk/metrics/configuration_patch.rb
Outdated
Show resolved
Hide resolved
* Default option is now OTLP * In-Memory option removed, it's not in the spec * PeriodicMetricReader added for both Console and OTLP exporters * Add the metrics OTLP exporter gem to the test gem group
| exporter: Metrics::Export::ConsoleMetricPullExporter.new | ||
| ) | ||
| ) | ||
| when 'otlp' |
There was a problem hiding this comment.
@mwear @xuan-cao-swi - The specs state that OTLP should be the default exporter or OTEL_METRICS_EXPORTER, so I updated the tests to reflect this and installed the OTLP exporter in the test group of the Gemile.
However, the OTLP exporter brings in the protobuf dependencies, making the entire metrics_sdk test suite incompatible with JRuby.
It seems like the tracing test suite gets around this by avoiding any mention of the OTLP exporter in the tests, even though the spec also expects OTLP to be the default exporter for that signal (the tests use zipkin instead).
I don't want to skip JRuby for all tests in the metrics_sdk.
My current thoughts for solutions are:
- conditionally install the OTLP exporter in the test environment if JRuby is present and skip the related tests if JRuby is present
- omit the OTLP exporter from the tests entirely, and bring in an alternate exporter for the tests, following the pattern for traces (in-memory metrics exporter seems like the best candidate, even though it's not part of the spec)
- something else...?
What do y'all think would be the best next step?
This PR updates the metrics configuration patch to match the functionality for traces in the
OpenTelemetry::SDK::Configurator.Once this PR is merged, the metric exporter can be automatically configured using the
OTLP_METRICS_EXPORTERenvironment variable.The environment variable has options for:
Like the Traces exporter, more than one exporter can be configured.
This draws a lot from the structure in: https://github.com/open-telemetry/opentelemetry-ruby/blob/main/sdk/lib/opentelemetry/sdk/configurator.rb
It intends to follow the specification: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/sdk-environment-variables.md?plain=1#L256