-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add markdownlint, markdown link check workflow and with updated markdown file #1096
chore: add markdownlint, markdown link check workflow and with updated markdown file #1096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @xuan-cao-swi! Few little things I saw, but this is great as-is. Happy we're getting these issues squared away.
Could you update your PR description to link the issues so that they close when this PR is merged?
The update could look something like:
Closes #547
Closes #981
Here's a doc on how the linking feature works: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
Co-authored-by: Kayla Reopelle <[email protected]>
Co-authored-by: Kayla Reopelle <[email protected]>
Looks like https://github.com/open-telemetry/community/ have a series of change 😕, and I couldn't find the replacement link (e.g. https://github.com/open-telemetry/community/blob/master/CONTRIBUTING.md). It seems like they just removed some of the link like https://github.com/open-telemetry/community/blob/master/community-membership.md#maintainer, and replace it directly with ruby repo contributing Link has been fixed. |
Strange! I used that community-membership link often. I'll open an issue on the repo to see if we can figure out what's replaced those two files. I think you have a good workaround for now. |
@xuan-cao-swi - One replacement for the community CONTRIBUTING.md file could be this new contributor experience guide: https://github.com/open-telemetry/community/blob/main/guides/contributor/README.md |
@xuan-cao-swi - The membership doc lives here now: https://github.com/open-telemetry/community/blob/main/guides/contributor/membership.md Could you add it back to the files? |
Yes, I changed the link to https://github.com/open-telemetry/community/blob/main/guides/contributor/membership.md. Sorry for the confusion, I mean I fixed the link in our README for |
Description
This PR attempts to address #547 (remove gitter) and #981.
CHANGELOG.md
file (e.g.,!**/CHANGELOG.md
). This is becauseCHANGELOG.md
is believed to be auto-generated based on PR titles. Any issues with this file could potentially cause the entire workflow to fail.Closes #547
Closes #981