feat(active-job)!: Normalize event messages #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavoiesl
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle and
xuan-cao-swi
as code owners
bensheldon
approved these changes
Jul 22, 2024
lavoiesl
changed the title
lavoiesl
force-pushed
the
seb-active_job-default-events
branch
2 times, most recently
from
67bda51
to
b5fc587
Compare
lavoiesl
force-pushed
the
seb-active_job-default-events
branch
from
b5fc587
to
fb6b493
Compare
|
Here we go 👍🏼 |
|
@lavoiesl - Thank you for fixing the merge conflicts! I missed your update after another PR was merged into main. 😞 Could you merge |
lavoiesl
force-pushed
the
seb-active_job-default-events
branch
from
fb6b493
to
ea1cc33
Compare
|
Rebased. |
kaylareopelle
approved these changes
Jul 30, 2024
kaylareopelle
changed the title
kaylareopelle
changed the title
kaylareopelle
approved these changes
Jul 30, 2024
|
@kaylareopelle updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Designed to be merged after #1079
Related to:
Currently, active job events are:
enqueue.active_job#{prefix} publish#{prefix} publishenqueue_at.active_job#{prefix} publish#{prefix} publishenqueue_retry.active_jobenqueue_retry.active_job#{prefix} enqueue_retryperform.active_job#{prefix} process#{prefix} processretry_stopped.active_jobretry_stopped.active_job#{prefix} retry_stoppeddiscard.active_jobdiscard.active_job#{prefix} discardPrefix being the queue name or the job class, depending on config.
I think this is more consistent.