feat: Use Default Span Name Format #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It also allows users to rollback to legacy span name format. Follow up to open-telemetry#1014
arielvalentin
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle and
xuan-cao-swi
as code owners
kaylareopelle
approved these changes
Jun 24, 2024
instrumentation/action_view/lib/opentelemetry/instrumentation/action_view/instrumentation.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
arielvalentin
added a commit
to arielvalentin/opentelemetry-ruby-contrib
that referenced
this pull request
Aug 8, 2024
This reverts commit f999e70.
arielvalentin
added a commit
to arielvalentin/opentelemetry-ruby-contrib
that referenced
this pull request
Aug 8, 2024
This reverts commit f999e70.
arielvalentin
added a commit
that referenced
this pull request
Aug 8, 2024
arielvalentin
added a commit
to arielvalentin/opentelemetry-ruby-contrib
that referenced
this pull request
Aug 22, 2024
This restores the functionality that was reverted 94c3c3b. I had originally introduced this functionality in this PR: open-telemetry#1039 cc: @mrsimo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also allows users to rollback to legacy span name format.
Follow up to #1014