Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @open-telemetry/profiling-maintainers as CODEOWNERS #550

Conversation

tigrannajaryan
Copy link
Member

No description provided.

@tigrannajaryan
Copy link
Member Author

@open-telemetry/technical-committee please approve the changes.

@tigrannajaryan
Copy link
Member Author

Hmm, for some reasons I am unable to merge this although it shows we have 2 approvals (the required number). Weird. Can I get more approvals to see if it makes a difference?

@arminru arminru merged commit a4caf75 into open-telemetry:main May 7, 2024
29 checks passed
@arminru
Copy link
Member

arminru commented May 7, 2024

@tigrannajaryan It was just lacking an owners approval for the CODEOWNERS file itself as per:

*   @open-telemetry/specs-semconv-approvers 

@tigrannajaryan tigrannajaryan deleted the feature/tigran/add-prof-maintainers branch May 7, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants