Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s container id detection #191

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Sep 14, 2023

update container detection to follow current best-practise, per bug report. we should check v1 then v2, and a few other updates I ripped off from java's implementation. adding tests for k8s and podman, and break inline content out into fixtures.

Fixes: open-telemetry/opentelemetry-php#1114

update container detection to follow current best-practise, per bug report. we should check
v1 then v2, and a few other updates I ripped off from java's implementation.
adding tests for k8s and podman, and break inline content out into fixtures.
@brettmc brettmc requested a review from a team September 14, 2023 03:34
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #191 (33dc028) into main (c8e79a8) will increase coverage by 0.26%.
The diff coverage is 92.30%.

❗ Current head 33dc028 differs from pull request most recent head 737ddab. Consider uploading reports for the commit 737ddab to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #191      +/-   ##
============================================
+ Coverage     28.60%   28.87%   +0.26%     
- Complexity      472      474       +2     
============================================
  Files            47       47              
  Lines          1755     1763       +8     
============================================
+ Hits            502      509       +7     
- Misses         1253     1254       +1     
Flag Coverage Δ
7.4 52.68% <92.30%> (+0.38%) ⬆️
8.0 28.17% <92.30%> (+0.31%) ⬆️
8.1 28.24% <92.30%> (+0.31%) ⬆️
8.2 28.88% <92.30%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage
src/ResourceDetectors/Container/src/Container.php 92.30%

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e79a8...737ddab. Read the comment docs.

@brettmc brettmc merged commit a973a41 into open-telemetry:main Sep 15, 2023
52 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"container.id" resource attribute is wrong
2 participants