Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrib: Reducing package size #188

Merged
merged 19 commits into from
Aug 23, 2023

Conversation

ChrisLightfootWild
Copy link
Contributor

@ChrisLightfootWild ChrisLightfootWild commented Aug 23, 2023

Following on from #187:

I've gone through the gitsplit config to identify each of the separate packages to target (hopefully I've not missed any!).

This command is a helpful check (if you run it in the package base directory):

eg:

cd src/Aws
git archive --format tar HEAD | tar t

@ChrisLightfootWild ChrisLightfootWild requested a review from a team August 23, 2023 13:27
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #188 (4485006) into main (e0b132c) will decrease coverage by 1.46%.
The diff coverage is n/a.

❗ Current head 4485006 differs from pull request most recent head 76fcd33. Consider uploading reports for the commit 76fcd33 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #188      +/-   ##
============================================
- Coverage     36.18%   34.73%   -1.46%     
- Complexity      788      814      +26     
============================================
  Files            68       71       +3     
  Lines          2954     3078     +124     
============================================
  Hits           1069     1069              
- Misses         1885     2009     +124     
Flag Coverage Δ
7.4 46.18% <ø> (+8.19%) ⬆️
8.0 34.79% <ø> (-6.09%) ⬇️
8.1 34.82% <ø> (-6.03%) ⬇️
8.2 34.67% <ø> (-7.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0b132c...76fcd33. Read the comment docs.

@brettmc brettmc merged commit 1bc2e84 into open-telemetry:main Aug 23, 2023
55 checks passed
@ChrisLightfootWild ChrisLightfootWild deleted the packaging/reduction branch August 23, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants