Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update psr3 auto-instrumentation #178

Merged
merged 10 commits into from
Jul 31, 2023
Merged

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Jul 11, 2023

adding some new features to psr-3 auto-instrumentation:

  • ability to inject context (as before), or emit the log in otlp format
  • adding tests against different psr-3 implementations
  • adding some env vars to control the behaviour of the package
  • examples

adding some new features to psr-3 auto-instrumentation:
* ability to inject context (as before), or emit the log in otlp format
* adding tests against different psr-3 implementations
* adding some env vars to control the behaviour of the package
* examples
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #178 (341d6d9) into main (b6dd2a4) will increase coverage by 2.14%.
Report is 6 commits behind head on main.
The diff coverage is 40.45%.

❗ Current head 341d6d9 differs from pull request most recent head b66fef6. Consider uploading reports for the commit b66fef6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #178      +/-   ##
============================================
+ Coverage     32.64%   34.79%   +2.14%     
- Complexity      783      811      +28     
============================================
  Files            69       71       +2     
  Lines          2971     3072     +101     
============================================
+ Hits            970     1069      +99     
- Misses         2001     2003       +2     
Flag Coverage Δ
7.4 46.18% <ø> (+0.07%) ⬆️
8.0 34.86% <25.35%> (+<0.01%) ⬆️
8.1 34.90% <25.35%> (+7.03%) ⬆️
8.2 34.74% <40.45%> (+10.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...c/Instrumentation/Psr3/src/Psr3Instrumentation.php 0.00% <0.00%> (ø)
...Symfony/src/OtelBundle/Console/ConsoleListener.php 62.79% <ø> (ø)
...tion/Compiler/SetAliasIfNotDefinedCompilerPass.php 100.00% <ø> (ø)
...c/OtelBundle/DependencyInjection/Configuration.php 100.00% <ø> (ø)
...c/OtelBundle/DependencyInjection/OtelExtension.php 100.00% <ø> (ø)
...ny/src/OtelBundle/HttpKernel/HeadersPropagator.php 100.00% <ø> (ø)
...fony/src/OtelBundle/HttpKernel/RequestListener.php 77.34% <ø> (ø)
src/Symfony/src/OtelBundle/OtelBundle.php 58.33% <ø> (+16.66%) ⬆️
...fony/src/OtelBundle/Resources/services_console.php 0.00% <ø> (ø)
...mfony/src/OtelBundle/Resources/services_kernel.php 0.00% <ø> (ø)
... and 17 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6dd2a4...b66fef6. Read the comment docs.

@brettmc brettmc marked this pull request as ready for review July 12, 2023 05:11
@brettmc brettmc requested a review from a team July 12, 2023 05:11
@brettmc brettmc merged commit 33b3624 into open-telemetry:main Jul 31, 2023
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants