monolog scope name from channel #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* exceptions were being emitted as an array under the 'exception' key, which does not
conform to our new enforcement that array attribute values must be homogeneous. Instead,
format the exception to use the proper sementic convention attributes ('exception.xyz`)
* do not emit context + extra as their own attribute keys. This will very often break
the 'must be homogeneous' test, so move them up to top-level attribute (with context
taking precedence if the same key exists in both)
* use the monolog channel name to create a scope for each channel (which means now
the logger will create and reference one logger per scope/channel)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
============================================
+ Coverage 7.98% 33.27% +25.29%
- Complexity 239 762 +523
============================================
Files 24 66 +42
Lines 952 2897 +1945
============================================
+ Hits 76 964 +888
- Misses 876 1933 +1057
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 32 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
the original code was correct, but required an upstream (sdk) fix to support complex attributes for a LogRecord
brettmc
changed the title
bobstrecansky
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: open-telemetry/opentelemetry-php#1049