Laravel: nullify missing attributes to reduce noise.

open-telemetry · Oct 2, 2024 · ee8cebe · ee8cebe
1 parent 45a6932
commit ee8cebe
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/Instrumentation/Laravel/src/Watchers/ClientRequestWatcher.php b/src/Instrumentation/Laravel/src/Watchers/ClientRequestWatcher.php
@@ -58,10 +58,10 @@ public function recordRequest(RequestSending $request): void
             ->setAttributes([
                 TraceAttributes::HTTP_REQUEST_METHOD => $request->request->method(),
                 TraceAttributes::URL_FULL => $processedUrl,
-                TraceAttributes::URL_PATH => $parsedUrl['path'] ?? '',
-                TraceAttributes::URL_SCHEME => $parsedUrl['scheme'] ?? '',
-                TraceAttributes::SERVER_ADDRESS => $parsedUrl['host'] ?? '',
-                TraceAttributes::SERVER_PORT => $parsedUrl['port'] ?? '',
+                TraceAttributes::URL_PATH => $parsedUrl['path'] ?? null,
+                TraceAttributes::URL_SCHEME => $parsedUrl['scheme'] ?? null,
+                TraceAttributes::SERVER_ADDRESS => $parsedUrl['host'] ?? null,
+                TraceAttributes::SERVER_PORT => $parsedUrl['port'] ?? null,
             ])
             ->startSpan();
         $this->spans[$this->createRequestComparisonHash($request->request)] = $span;