-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user-specified instrumentation volume #3285
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me overall. Some things missing before we can merge this PR:
- You need to add a changelog entry. Run
make chlog-new
and fill in the template. - Run
make precommit
and fix any issues it brings up. Right now, the CI is failing because the bundle needs to be updated after changes to CRDs. - We should check this volume mechanism in E2E tests. It's fine to modify an existing test.
Thanks, got it working locally! Was using golang v1.23.x and pipeline was broken on me, so I downgraded. |
The PR looks great, thanks for the contribution! There's one big problem with it, and to be clear, this is really Kubernetes' fault. As it turns out, the OpenAPI spec for I'm not sure what we can do to alleviate this. We could make the |
Description:
Adds the ability for user to specify a custom volume for instrumentation / auto-injection to
Instrumentation.spec.<lang>.volumeSizeLimit
.Adds validation to prevent
Volume
andVolumeSizeLimit
being defined simultaneously to prevent overlapping behavior (ex. Do we useVolume.Size
orVolumeSizeLimit
?)Link to tracking Issue(s):
Testing:
Unit tests for validation with different combinations of Volume/VolumeSizeLimit being defined and not defined
Documentation:
Updated API docs with new spec.