Default to UDP protocol for xray receiver #3263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
reviewed
Sep 4, 2024
internal/manifests/collector/parser/receiver/receiver_aws-xray.go
Outdated
Show resolved
Hide resolved
jaronoff97
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The awsxray receiver's service and deployment should default to UDP 2000 instead of TCP 2000.
Currently the collector pod/container is unreachable, when someone tries to spin up an xray receiver because the pod is listening on the UDP port, but the service and the deployment is exposing TCP.
From the awsxray-receiver README:
I looked to #1433 for implementation guidance.
Let me know how, if any changes are needed to get this merged.
Link to tracking Issue(s):
Testing:
Documentation: