Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add markdown lint check to default lint command #5074

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

maryliag
Copy link
Contributor

Add the lint checks for markdown to the npm run lint command, to align the local command with what is being executed on github workflow.

Without this change the lint was taking 31s, and after it kept at 31s.

@maryliag maryliag requested a review from a team as a code owner October 16, 2024 17:19
@maryliag maryliag changed the title Lint chore: add markdown lint check to default lint command Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.27%. Comparing base (c208991) to head (db2251c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5074      +/-   ##
==========================================
+ Coverage   93.26%   93.27%   +0.01%     
==========================================
  Files         317      317              
  Lines        8195     8195              
  Branches     1641     1641              
==========================================
+ Hits         7643     7644       +1     
+ Misses        552      551       -1     

see 1 file with indirect coverage changes

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to update this and the CONTRIBUTING.md.
Please also adapt the lint workflow - so that the script does not run twice in CI 🙂

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@maryliag
Copy link
Contributor Author

Please also adapt the lint workflow

done

@pichlermarc pichlermarc added this pull request to the merge queue Oct 17, 2024
Merged via the queue into open-telemetry:main with commit be1737f Oct 17, 2024
21 checks passed
@maryliag maryliag deleted the lint branch October 17, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants