-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added limitation in ot-shim readme #5072
base: main
Are you sure you want to change the base?
Conversation
Hi @pichlermarc I'd appreciate your review. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for working on this - a few suggestions as per my understanding of the issue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5072 +/- ##
==========================================
+ Coverage 93.26% 93.27% +0.01%
==========================================
Files 317 317
Lines 8195 8195
Branches 1641 1641
==========================================
+ Hits 7643 7644 +1
+ Misses 552 551 -1 |
Co-authored-by: Marc Pichler <[email protected]>
Co-authored-by: Marc Pichler <[email protected]>
@pichlermarc I have committed your suggestions. Thanks. |
Which problem is this PR solving?
This PR informs users that the OpenTracing shim doesn't include a scope manager.
Fixes #2700
Short description of the changes
This PR updates the OpenTracing shim
Readme.md
file by adding a limitation section; informing users that the OpenTracing shim doesn't include a scope manager.Type of change
How Has This Been Tested?
No test was created/run
Checklist: