Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(otlp-grpc-exporter-base): do not use hard-coded version in tests, touch up changelog entries #5069

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

See test failure in #5068, after we updated the versions, the tests failed because they were hardcoded. This PR fixes this, and also moves some changelog entries to the correct spot (I had put them in bugfix but they belong in the breaking changes section).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit tests

@pichlermarc pichlermarc requested a review from a team as a code owner October 14, 2024 16:29
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.27%. Comparing base (a1442fe) to head (d5d7839).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5069      +/-   ##
==========================================
+ Coverage   93.26%   93.27%   +0.01%     
==========================================
  Files         317      317              
  Lines        8195     8195              
  Branches     1641     1641              
==========================================
+ Hits         7643     7644       +1     
+ Misses        552      551       -1     

see 1 file with indirect coverage changes

@david-luna david-luna added this pull request to the merge queue Oct 15, 2024
Merged via the queue into open-telemetry:main with commit 7ed67f9 Oct 15, 2024
21 checks passed
@pichlermarc pichlermarc deleted the test/no-hardcoded-versions branch October 15, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants