Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(exporter-logs-otlp-proto): Use correct config type in constructor #5058

Merged
merged 2 commits into from
Oct 10, 2024
Merged

fix(exporter-logs-otlp-proto): Use correct config type in constructor #5058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8806729
fix(exporter-logs-otlp-proto): use correct config type in constructor
raphael-theriault-swi Oct 9, 2024
33f17b9
chore: update changelog
raphael-theriault-swi Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions experimental/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ All notable changes to experimental packages in this project will be documented
* `configureExporterTimeout`
* `invalidTimeout`
* fix(sdk-node): use warn instead of error on unknown OTEL_NODE_RESOURCE_DETECTORS values [#5034](https://github.com/open-telemetry/opentelemetry-js/pull/5034)
* fix(exporter-logs-otlp-proto): Use correct config type in Node constructor

### :books: (Refine Doc)

Expand Down
4 changes: 2 additions & 2 deletions experimental/packages/exporter-logs-otlp-proto/src/platform/node/OTLPLogExporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
*/

import {
OTLPExporterConfigBase,
OTLPExporterNodeBase,
OTLPExporterNodeConfigBase,
} from '@opentelemetry/otlp-exporter-base';
import {
IExportLogsServiceResponse,
Expand All @@ -37,7 +37,7 @@ export class OTLPLogExporter
extends OTLPExporterNodeBase<ReadableLogRecord, IExportLogsServiceResponse>
implements LogRecordExporter
{
constructor(config: OTLPExporterConfigBase = {}) {
constructor(config: OTLPExporterNodeConfigBase = {}) {
super(
config,
ProtobufLogsSerializer,
Expand Down
Loading