chore(exporter-zipkin): remove usages of Span constructor #5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-luna
commented
Oct 1, 2024
packages/opentelemetry-exporter-zipkin/test/common/transform.test.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5030 +/- ##
==========================================
- Coverage 93.39% 93.26% -0.14%
==========================================
Files 46 317 +271
Lines 712 8194 +7482
Branches 120 1640 +1520
==========================================
+ Hits 665 7642 +6977
- Misses 47 552 +505 |
pichlermarc
approved these changes
Oct 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The Span constructor from ' @opentelemetry/sdk-trace-base` is planned for removal from the public API . This PR anticipates the possible breaking changes derived from it
Refs #3597
Short description of the changes
new Spanconstructor in favour ofTracer.startSpanType of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: