Run the test compatibility check even if tests failed #5879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
requested review from
MrAlias,
XSAM,
dashpole and
pellared
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5879 +/- ##
=====================================
Coverage 84.5% 84.5%
=====================================
Files 272 272
Lines 22840 22840
=====================================
Hits 19312 19312
Misses 3179 3179
Partials 349 349 |
MrAlias
approved these changes
Oct 10, 2024
pellared
approved these changes
Oct 11, 2024
|
Merging as trivial chore and important for CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces the test compatibility check to run, even if compatibility test checks have failed, as having it skipped still allows merging PRs.
Related: open-telemetry/opentelemetry-go-contrib#6224