Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] sdk/log: Do not create instances of Record #5871

Merged
merged 1 commit into from
Oct 4, 2024
Merged

[doc] sdk/log: Do not create instances of Record #5871

merged 1 commit into from
Oct 4, 2024

Conversation

pellared
Copy link
Member

@pellared pellared commented Oct 3, 2024

Fixes #5823

@pellared pellared added documentation Provides helpful information pkg:SDK Related to an SDK package area:logs Part of OpenTelemetry logs Skip Changelog PRs that do not require a CHANGELOG.md entry labels Oct 3, 2024
@pellared pellared self-assigned this Oct 3, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.5%. Comparing base (d37e1ef) to head (d6e2211).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5871   +/-   ##
=====================================
  Coverage   84.5%   84.5%           
=====================================
  Files        272     272           
  Lines      22734   22734           
=====================================
+ Hits       19227   19228    +1     
+ Misses      3164    3163    -1     
  Partials     343     343

see 2 files with indirect coverage changes

@pellared pellared merged commit 3da26f0 into open-telemetry:main Oct 4, 2024
40 checks passed
@MrAlias MrAlias added this to the v1.31.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@dashpole dashpole dashpole approved these changes

@MrAlias MrAlias Awaiting requested review from MrAlias MrAlias is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung

Assignees

@pellared pellared

Labels
area:logs Part of OpenTelemetry logs documentation Provides helpful information pkg:SDK Related to an SDK package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
Go: Logs (GA)
Status: Done
Milestone
v1.31.0
Development

Successfully merging this pull request may close these issues.

sdk/log: Document that users should not create instances of Record
4 participants
@pellared @dmathieu @dashpole @MrAlias