-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance improvements for recordingSpan
SetAttributes
and addOverCapAttrs
#5864
Merged
dmathieu
merged 8 commits into
open-telemetry:main
from
boekkooi-impossiblecloud:attributes-tweaks
Oct 7, 2024
Merged
Performance improvements for recordingSpan
SetAttributes
and addOverCapAttrs
#5864
dmathieu
merged 8 commits into
open-telemetry:main
from
boekkooi-impossiblecloud:attributes-tweaks
Oct 7, 2024
Commits on Oct 2, 2024
-
trace: SetAttributes only when attributes are provided
benchstat: ``` goos: linux goarch: amd64 pkg: go.opentelemetry.io/otel/sdk/trace cpu: 11th Gen Intel(R) Core(TM) i5-11400H @ 2.70GHz │ new.txt │ new1.txt │ │ sec/op │ sec/op vs base │ TraceStart/with_a_simple_span-12 451.0n ± 5% 375.0n ± 1% -16.85% (p=0.000 n=10) TraceStart/with_several_links-12 595.8n ± 3% 501.7n ± 1% -15.80% (p=0.000 n=10) TraceStart/with_attributes-12 644.5n ± 10% 569.5n ± 4% -11.63% (p=0.000 n=10) geomean 557.4n 474.9n -14.79% │ new.txt │ new1.txt │ │ B/op │ B/op vs base │ TraceStart/with_a_simple_span-12 496.0 ± 0% 496.0 ± 0% ~ (p=1.000 n=10) ¹ TraceStart/with_several_links-12 672.0 ± 0% 672.0 ± 0% ~ (p=1.000 n=10) ¹ TraceStart/with_attributes-12 752.0 ± 0% 752.0 ± 0% ~ (p=1.000 n=10) ¹ geomean 630.5 630.5 +0.00% ¹ all samples are equal │ new.txt │ new1.txt │ │ allocs/op │ allocs/op vs base │ TraceStart/with_a_simple_span-12 2.000 ± 0% 2.000 ± 0% ~ (p=1.000 n=10) ¹ TraceStart/with_several_links-12 3.000 ± 0% 3.000 ± 0% ~ (p=1.000 n=10) ¹ TraceStart/with_attributes-12 4.000 ± 0% 4.000 ± 0% ~ (p=1.000 n=10) ¹ geomean 2.884 2.884 +0.00% ¹ all samples are equal ```
Configuration menu - View commit details
-
Copy full SHA for 13b53c9 - Browse repository at this point
Copy the full SHA 13b53c9View commit details -
fix: grow s.attributes only when needed
Grow increases the slice's capacity, if necessary, to guarantee space for another n elements. This change now ensures that `n` is the amount of elements to grow and not the capacity amount.
Configuration menu - View commit details
-
Copy full SHA for ef84c7b - Browse repository at this point
Copy the full SHA ef84c7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3737aec - Browse repository at this point
Copy the full SHA 3737aecView commit details
Commits on Oct 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 48156c1 - Browse repository at this point
Copy the full SHA 48156c1View commit details
Commits on Oct 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f6fd877 - Browse repository at this point
Copy the full SHA f6fd877View commit details -
Co-authored-by: Damien Mathieu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6185ce3 - Browse repository at this point
Copy the full SHA 6185ce3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bc49cf - Browse repository at this point
Copy the full SHA 6bc49cfView commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c8f11cb - Browse repository at this point
Copy the full SHA c8f11cbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.