Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the synchronous gauge to the metric API and SDK #5304

Merged
merged 20 commits into from
May 16, 2024

Merge branch 'main' into sync-gauge

455421c
Select commit
Loading
Failed to load commit list.
Merged

Add the synchronous gauge to the metric API and SDK #5304

Merge branch 'main' into sync-gauge
455421c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 16, 2024 in 1s

84.5% (-0.1%) compared to 166b347

View this Pull Request on Codecov

84.5% (-0.1%) compared to 166b347

Details

Codecov Report

Attention: Patch coverage is 74.73684% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 84.5%. Comparing base (166b347) to head (455421c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5304     +/-   ##
=======================================
- Coverage   84.6%   84.5%   -0.1%     
=======================================
  Files        268     268             
  Lines      17704   17794     +90     
=======================================
+ Hits       14982   15050     +68     
- Misses      2410    2430     +20     
- Partials     312     314      +2     
Files Coverage Δ
internal/global/meter.go 95.3% <100.0%> (+0.4%) ⬆️
metric/instrument.go 100.0% <100.0%> (ø)
metric/noop/noop.go 100.0% <100.0%> (ø)
metric/syncfloat64.go 100.0% <100.0%> (ø)
metric/syncint64.go 100.0% <100.0%> (ø)
sdk/metric/instrument.go 100.0% <ø> (ø)
sdk/metric/instrumentkind_string.go 50.0% <ø> (ø)
sdk/metric/reader.go 100.0% <100.0%> (ø)
sdk/metric/pipeline.go 88.7% <75.0%> (+0.1%) ⬆️
internal/global/instruments.go 63.6% <66.6%> (+0.4%) ⬆️
... and 1 more