Add export sync #5105
Merged
Add export sync #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The batching log processor will generate records from 4 different locations (polling, OnEmit, ForceFlush, Shutdown). In order to ensure an Exporter is called serially, as is required by the interface, this function will be used in the processor to centralize the interaction with its Exporter. Part of open-telemetry#5063. See open-telemetry#5093 for the implementation use.
MrAlias
added
area:logs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5105 +/- ##
=====================================
Coverage 83.8% 83.8%
=====================================
Files 248 248
Lines 16203 16221 +18
=====================================
+ Hits 13581 13599 +18
Misses 2334 2334
Partials 288 288
|
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
dmathieu
approved these changes
Mar 26, 2024
dashpole
reviewed
Mar 27, 2024
Locking around the exporter would mean the calling goroutine would need to wait for the export to complete before continuing. Either the batching processor routine, or the polling routine will be blocked in that case. Either of which is going to be problematic as it could cause large back-pressure for systems with high throughput. Passing via a channel to a separate goroutine will allow the the export to not block, and if the export becomes excessively slow we can start dropping payloads instead of locking up. |
dashpole
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The batching log processor will generate records from 4 different locations (polling, OnEmit, ForceFlush, Shutdown). In order to ensure an Exporter is called serially, as is required by the interface, this function will be used in the processor to centralize the interaction with its Exporter.
Part of #5063.
See #5093 for the implementation use.