Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade use of semconv to v1.24.0 #4754

Merged
merged 19 commits into from
Jan 11, 2024

Conversation

pellared
Copy link
Member

@pellared pellared commented Dec 12, 2023

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (259143a) 82.3% compared to head (c10e583) 82.3%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4754   +/-   ##
=====================================
  Coverage   82.3%   82.3%           
=====================================
  Files        226     226           
  Lines      18401   18406    +5     
=====================================
+ Hits       15148   15153    +5     
  Misses      2969    2969           
  Partials     284     284           
Files Coverage Δ
bridge/opentracing/internal/mock.go 67.0% <ø> (ø)
...otlpmetric/otlpmetricgrpc/internal/otest/client.go 97.1% <ø> (ø)
...otlpmetric/otlpmetrichttp/internal/otest/client.go 97.1% <ø> (ø)
exporters/zipkin/model.go 94.8% <100.0%> (+0.1%) ⬆️
sdk/resource/builtin.go 90.3% <ø> (ø)
sdk/resource/container.go 92.3% <ø> (ø)
sdk/resource/env.go 94.0% <ø> (ø)
sdk/resource/host_id.go 97.4% <ø> (ø)
sdk/resource/os.go 93.4% <ø> (ø)
sdk/resource/process.go 98.4% <ø> (ø)
... and 1 more

CHANGELOG.md Outdated Show resolved Hide resolved
@pellared pellared changed the title Upgrade use of semconv to use v1.23.1 [DoNotMerge] Upgrade use of semconv to use v1.23.1 Dec 12, 2023
@pellared pellared marked this pull request as ready for review December 12, 2023 11:49
@pellared pellared changed the title [DoNotMerge] Upgrade use of semconv to use v1.23.1 [DoNotMerge] Upgrade use of semconv to v1.23.1 Dec 12, 2023
@pellared pellared changed the title [DoNotMerge] Upgrade use of semconv to v1.23.1 Upgrade use of semconv to v1.23.1 Dec 14, 2023
@pellared pellared marked this pull request as draft December 15, 2023 06:32
@pellared pellared added this to the v1.22.0 milestone Dec 15, 2023
@pellared pellared added the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Dec 15, 2023
@pellared pellared changed the title Upgrade use of semconv to v1.23.1 Upgrade use of semconv to v1.24.0 Dec 19, 2023
@pellared pellared self-assigned this Dec 19, 2023
@pellared pellared changed the title Upgrade use of semconv to v1.24.0 [DoNotMerge] Upgrade use of semconv to v1.24.0 Dec 22, 2023
@pellared pellared marked this pull request as ready for review December 22, 2023 12:58
CHANGELOG.md Outdated Show resolved Hide resolved
@pellared pellared changed the title [DoNotMerge] Upgrade use of semconv to v1.24.0 Upgrade use of semconv to v1.24.0 Jan 10, 2024
@pellared pellared removed the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Jan 10, 2024
@pellared
Copy link
Member Author

I plan to merge this tomorrow.

@pellared pellared merged commit 01472db into open-telemetry:main Jan 11, 2024
25 checks passed
@pellared pellared deleted the use-semconv-1.23.1 branch January 11, 2024 11:56
@@ -25,6 +25,8 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

### Changed

- Upgrade all use of `go.opentelemetry.io/otel/semconv` to use `v1.24.0`. (#4754)
- Update transformations in `go.opentelemetry.io/otel/exporters/zipkin` to follow `v1.19.0` version of the OpenTelemetry specification. (#4754)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot more like it's using v1.24.0. May lead to confusion?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. Thanks ❤️

pellared added a commit to pellared/opentelemetry-go that referenced this pull request Jan 31, 2024
pellared added a commit that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade all use of go.opentelemetry.io/otel/semconv to use v1.24.0
6 participants