Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk/metric: Add unit tests for Shutdown WithTimeout #4379

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

pellared
Copy link
Member

@pellared pellared commented Jul 28, 2023

EDIT after #4377 is merged:

Add tests which are are almost copies of existing tests.

@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #4379 (e3c1569) into main (528a0cb) will increase coverage by 0.0%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head e3c1569 differs from pull request most recent head 6c3dfcb. Consider uploading reports for the commit 6c3dfcb to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4379   +/-   ##
=====================================
  Coverage   83.4%   83.4%           
=====================================
  Files        184     184           
  Lines      14380   14380           
=====================================
+ Hits       11997   11999    +2     
+ Misses      2155    2153    -2     
  Partials     228     228           

see 2 files with indirect coverage changes

@pellared pellared changed the title sdk/metric: Improve WithTimeout doc sdk/metric: Add unit tests for Shutdown WithTimeout Jul 30, 2023
sdk/metric/periodic_reader_test.go Show resolved Hide resolved
@MrAlias MrAlias merged commit c4d2d7c into open-telemetry:main Aug 2, 2023
19 checks passed
@pellared pellared deleted the improve-WithTimeout-doc branch August 2, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants