-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle 2xx as success for OTLP HTTP trace and metric exporters #4365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared and
hanyuancheung
as code owners
July 26, 2023 10:16
pellared
reviewed
Jul 26, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4365 +/- ##
=======================================
- Coverage 83.5% 83.5% -0.1%
=======================================
Files 229 229
Lines 18653 18679 +26
=======================================
+ Hits 15584 15605 +21
- Misses 2751 2755 +4
- Partials 318 319 +1
|
pellared
reviewed
Jul 26, 2023
pellared
approved these changes
Jul 26, 2023
Please update the PR title and description. |
dmathieu
changed the title
Handle 204 as success for HTTP traces and metric exporters
Handle 2xx as success for HTTP traces and metric exporters
Jul 26, 2023
MrAlias
approved these changes
Jul 27, 2023
MrAlias
changed the title
Handle 2xx as success for HTTP traces and metric exporters
Handle 2xx as success for OTLP HTTP trace and metric exporters
Jul 27, 2023
dashpole
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4363.