Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Histogram Boundry Hints #4340

Closed
wants to merge 1 commit into from

Conversation

MadVikingGod
Copy link
Contributor

  • Adds Histogram Boundry Hints to the Metric API
  • Plumbed through the pipelines so that hints + no aggregation selected in the view yields a histogram with the hints.

Cons:

  • This adds a specific creation path for histograms that is separate from the other instruments
  • Because the creation assumed that configuration came from the view, not from the API, the logic for the hints is buried meter -> InstProvider -> Resolver -> []inserters before the cache lookup is done.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #4340 (e588ae2) into main (c197fe9) will decrease coverage by 0.2%.
The diff coverage is 71.9%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4340     +/-   ##
=======================================
- Coverage   83.4%   83.3%   -0.2%     
=======================================
  Files        184     185      +1     
  Lines      14330   14370     +40     
=======================================
+ Hits       11957   11971     +14     
- Misses      2147    2171     +24     
- Partials     226     228      +2     
Impacted Files Coverage Δ
metric/syncfloat64.go 75.0% <0.0%> (-25.0%) ⬇️
metric/syncint64.go 75.0% <0.0%> (-25.0%) ⬇️
sdk/metric/pipeline.go 90.6% <84.2%> (-0.7%) ⬇️
sdk/metric/instrument.go 91.8% <100.0%> (ø)
sdk/metric/meter.go 86.0% <100.0%> (+0.1%) ⬆️

... and 3 files with indirect coverage changes

@MrAlias
Copy link
Contributor

MrAlias commented Jul 20, 2023

Prototype of #4162

@MrAlias
Copy link
Contributor

MrAlias commented Jul 20, 2023

Reviewed in the SIG, and we concluded this satisfies the PoC requirement. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants