Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove out of date example of internal usage. #4334

Merged

Conversation

MadVikingGod
Copy link
Contributor

Resolves #4331.

This removes the example file.

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #4334 (004874a) into main (63dfc4c) will increase coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4334   +/-   ##
=====================================
  Coverage   83.4%   83.4%           
=====================================
  Files        184     184           
  Lines      14350   14350           
=====================================
+ Hits       11975   11979    +4     
+ Misses      2149    2145    -4     
  Partials     226     226           

see 1 file with indirect coverage changes

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics Skip Changelog PRs that do not require a CHANGELOG.md entry labels Jul 17, 2023
@pellared pellared merged commit f6a658c into open-telemetry:main Jul 18, 2023
26 of 27 checks passed
@MadVikingGod MadVikingGod deleted the mvg/remove-internal-example branch July 18, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aggregator_example_test.go is out of date.
5 participants