Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ForceFlush() method to SpanProcessor interface #1166

Merged
merged 6 commits into from
Sep 20, 2020

Conversation

Aneurysm9
Copy link
Member

@Aneurysm9 Aneurysm9 commented Sep 11, 2020

  • Add a stub implementation to SimpleSpanProcessor
  • Add a working implementation to BatchSpanProcessor

Fixes #1072

* Add a stub implementation to SimpleSpanProcessor
* Add a working implementation to BatchSpanProcessor
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #1166 into master will decrease coverage by 0.8%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1166     +/-   ##
========================================
- Coverage    77.9%   77.0%   -0.9%     
========================================
  Files         135     135             
  Lines        7192    5867   -1325     
========================================
- Hits         5603    4521   -1082     
+ Misses       1346    1104    -242     
+ Partials      243     242      -1     
Impacted Files Coverage Δ
sdk/trace/batch_span_processor.go 78.4% <ø> (-0.1%) ⬇️
sdk/trace/simple_span_processor.go 66.6% <ø> (-13.4%) ⬇️
sdk/trace/trace_go11.go 50.0% <0.0%> (-10.0%) ⬇️
sdk/resource/resource.go 57.5% <0.0%> (-8.6%) ⬇️
api/trace/api.go 57.1% <0.0%> (-8.4%) ⬇️
api/metric/numberkind_string.go 16.6% <0.0%> (-8.4%) ⬇️
api/metric/must.go 41.3% <0.0%> (-8.2%) ⬇️
internal/testing/alignment.go 37.5% <0.0%> (-8.0%) ⬇️
sdk/metric/aggregator/sum/sum.go 68.0% <0.0%> (-7.8%) ⬇️
... and 127 more

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach looks good. Only question is a small one related to testing.

sdk/trace/batch_span_processor_test.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding ForceFlush() to Batch Span Processor
5 participants