split the span start/end benchmarks

open-telemetry · Jun 27, 2024 · 82b1cc0 · 82b1cc0
1 parent 0b1e0b2
commit 82b1cc0
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/sdk/trace/span_test.go b/sdk/trace/span_test.go
@@ -13,6 +13,7 @@ import (
 
 	"go.opentelemetry.io/otel/attribute"
 	"go.opentelemetry.io/otel/codes"
+	"go.opentelemetry.io/otel/trace"
 )
 
 func TestSetStatus(t *testing.T) {
@@ -277,3 +278,20 @@ func BenchmarkRecordingSpanSetAttributes(b *testing.B) {
 		})
 	}
 }
+
+func BenchmarkSpanEnd(b *testing.B) {
+	tracer := NewTracerProvider().Tracer("")
+	ctx := trace.ContextWithSpanContext(context.Background(), trace.SpanContext{})
+
+	spans := make([]trace.Span, b.N)
+	for i := 0; i < b.N; i++ {
+		_, span := tracer.Start(ctx, "")
+		spans[i] = span
+	}
+
+	b.ReportAllocs()
+	b.ResetTimer()
+	for i := 0; i < b.N; i++ {
+		spans[i].End()
+	}
+}
diff --git a/sdk/trace/trace_test.go b/sdk/trace/trace_test.go
@@ -2112,11 +2112,17 @@ func BenchmarkTraceStart(b *testing.B) {
 	tracer := NewTracerProvider().Tracer("")
 	ctx := trace.ContextWithSpanContext(context.Background(), trace.SpanContext{})
 
+	spans := make([]trace.Span, b.N)
 	b.ReportAllocs()
 	b.ResetTimer()
 
 	for i := 0; i < b.N; i++ {
 		_, span := tracer.Start(ctx, "")
-		span.End()
+		spans[i] = span
+	}
+
+	b.StopTimer()
+	for i := 0; i < b.N; i++ {
+		spans[i].End()
 	}
 }